Daniel Boles [Fri, 1 Sep 2017 10:52:12 +0000 (11:52 +0100)]
ComboBox: Remove pointless signal ID member fields
We don’t need to store these for disconnection, as we can just use
g_signal_handlers_disconnect_by_data().
Dušan Kazik [Fri, 1 Sep 2017 14:21:15 +0000 (14:21 +0000)]
Update Slovak translation
Daniel Boles [Thu, 31 Aug 2017 22:18:46 +0000 (23:18 +0100)]
ScrolledWindow: Fix non-disconnection of handlers
• Use disconnect_by_data() to catch both _adjustment_changed() and now
_adjustment_value_changed(), as the latter had been missed until now.
• Also disconnect from indicator_value_changed(), which was not done in
destroy() due to indicator_reset() and remove_indicator() disagreeing.
https://bugzilla.gnome.org/show_bug.cgi?id=775074
Daniel Boles [Thu, 31 Aug 2017 19:19:58 +0000 (20:19 +0100)]
Window: Do not connect to NULL screen in init()
Do not connect to get_settings_for_screen() if we have no screen…
Use g_signal_connect(), not connect_object(), to match how set_screen()
makes this same connection, and how finalize() already disconnects it.
https://bugzilla.gnome.org/show_bug.cgi?id=705640
Daniel Boles [Thu, 31 Aug 2017 18:58:15 +0000 (19:58 +0100)]
FileChooserWidget: Remove an unused #include
Daniel Boles [Tue, 29 Aug 2017 22:10:14 +0000 (23:10 +0100)]
gskenums: Fix typo/grammar in GskRenderNodeType doc
Matthias Clasen [Thu, 31 Aug 2017 03:22:03 +0000 (23:22 -0400)]
Avoid computing the same thing twice
Trivial cleanup.
Daniel Boles [Wed, 30 Aug 2017 20:14:56 +0000 (21:14 +0100)]
Entry: Rename int helper to gtk_entry_clear_icon()
It was called gtk_entry_clear(), which was unnecessarily vague.
Gábor Kelemen [Wed, 30 Aug 2017 18:18:25 +0000 (18:18 +0000)]
Update Hungarian translation
Gábor Kelemen [Wed, 30 Aug 2017 18:18:10 +0000 (18:18 +0000)]
Update Hungarian translation
Daniel Boles [Sat, 5 Aug 2017 22:48:29 +0000 (23:48 +0100)]
Entry: Fix Shift-click → extend/truncate selection
Since the move from button-press to gesture events, Shift-clicking did
not work to start a selection (from none) or truncate an existing one.
This was due to the code being copy-pasted around and some logic being
broken in the process. This makes both of those work as they should, by
shuffling it again so the end result is the same as before. Highlights:
(1) ::button-press if extending due to a single press would call
set_positions(tmp_pos, tmp_pos), which is what made the Shift+click to
create a selection work. That was lost. Add it back to make that work.
(2) ::button-press in the “Truncate current selection” branch would not
execute all the stuff around “extend_to_left”, as that was the else
case. So, set extend_selection = FALSE so we skip over that later on.
(3) BUT! This Truncate case never fired because it was in the else
branch of if (in_selection())! Of course, it must be in the true branch.
(4) The IM context was not reset if the Shift-click occurred within an
existing selection, only if it did not. In ::button-press this was the
first thing done if extending a selection, regardless. Make it so again.
https://bugzilla.gnome.org/show_bug.cgi?id=780750
Daniel Boles [Wed, 30 Aug 2017 13:22:54 +0000 (14:22 +0100)]
gl.po: Remove mnemonic underlines from tooltips
It looks like these were copy-paste errors from the corresponding labels
for buttons, which should have mnemonics. Of course, tooltips cannot.
Matthias Clasen [Wed, 30 Aug 2017 12:36:56 +0000 (08:36 -0400)]
Avoid empty space in the emoji chooser
We need to hide the empty flow boxes as well, to avoid
spacing between them.
https://bugzilla.gnome.org/show_bug.cgi?id=786966
Fabio Tomat [Wed, 30 Aug 2017 08:31:59 +0000 (08:31 +0000)]
Update Friulian translation
Nelson Benítez León [Wed, 2 Aug 2017 14:03:28 +0000 (19:03 +0500)]
textview: fix bug on DnD displaced limits of selection
The fix of commit
f2fd655754407103f8fb9b2c3e7586fb595ab917
should be confined to DnD coords only, because otherwise
it causes the start and end of the selection to be displaced.
https://bugzilla.gnome.org/show_bug.cgi?id=785736
Debarshi Ray [Mon, 28 Aug 2017 16:58:50 +0000 (18:58 +0200)]
GtkBuilder: Prefer "type-func" over "class" when looking for the GType
https://bugzilla.gnome.org/show_bug.cgi?id=786932
Милош Поповић [Tue, 29 Aug 2017 11:36:58 +0000 (11:36 +0000)]
Update Serbian Latin translation
Марко Костић [Tue, 29 Aug 2017 11:33:09 +0000 (11:33 +0000)]
Update Serbian translation
Timm Bäder [Tue, 29 Aug 2017 09:48:13 +0000 (11:48 +0200)]
GskRenderNode: Fix fallback border drawing
Rūdolfs Mazurs [Tue, 29 Aug 2017 09:19:09 +0000 (12:19 +0300)]
Update Latvian translation
Emin Tufan Çetin [Tue, 29 Aug 2017 05:39:03 +0000 (05:39 +0000)]
Update Turkish translation
Daniel Boles [Sat, 12 Aug 2017 15:13:11 +0000 (16:13 +0100)]
LevelBar: Really fix underallocation of blocks
Themes should not enforce min sizes on blocks in continuous mode; in
this case, the filled block should be as large as it needs to be to
reflect the current value, and no larger or smaller than that. So, the
fact that the minimal size was selected on just levelbar block is wrong:
we should also require the levelbar.discrete class to apply min sizes.
The widget should enforce whatever correct minimum size results from the
above fix, by reapplying commit
78b4885fe8850e132d8bb06df8ab90ac6c2033e0
Except: we should not allocate/draw the filled block if the value is 0,
as in this case, the LevelBar should be empty, not have a min-size fill.
This partially reverts commit
96062ffeae5245fa165a96a2af86d5645f5e8569,
as it makes sense to set min sizes for discrete blocks, so keep that in.
https://bugzilla.gnome.org/show_bug.cgi?id=783649
Javier Jardón [Fri, 4 Aug 2017 14:12:12 +0000 (15:12 +0100)]
gtk/gtkshow: Remove deprected gtk_show_uri()
Javier Jardón [Fri, 4 Aug 2017 14:11:36 +0000 (15:11 +0100)]
Use gtk_show_uri_on_window() instead gtk_show_uri()
Daniel Boles [Mon, 28 Aug 2017 19:35:47 +0000 (20:35 +0100)]
Entry: Handle :show-emoji-icon becoming false
Disconnect the now-unwanted signal handler, and hide the icon.
https://bugzilla.gnome.org/show_bug.cgi?id=786940
Daniel Boles [Mon, 28 Aug 2017 19:34:49 +0000 (20:34 +0100)]
Entry: Drop redundant typecasts
https://bugzilla.gnome.org/show_bug.cgi?id=786940
Daniel Boles [Mon, 28 Aug 2017 19:26:48 +0000 (20:26 +0100)]
Entry: Only open emoji picker on 2ndary icon click
We hijack the secondary icon for the emoji picker, but the handler for
::icon-press did not check the pressed icon and opened it for either.
https://bugzilla.gnome.org/show_bug.cgi?id=786938
Ask Hjorth Larsen [Mon, 28 Aug 2017 17:27:30 +0000 (19:27 +0200)]
Updated Danish translation
Ask Hjorth Larsen [Mon, 28 Aug 2017 17:25:52 +0000 (19:25 +0200)]
Updated Danish translation
Matej Urbančič [Mon, 28 Aug 2017 17:24:58 +0000 (19:24 +0200)]
Updated Slovenian translation
Matej Urbančič [Mon, 28 Aug 2017 17:19:53 +0000 (19:19 +0200)]
Updated Slovenian translation
Timm Bäder [Mon, 28 Aug 2017 15:48:25 +0000 (17:48 +0200)]
gskrendernode: Fix inset shadow drawing
Timm Bäder [Mon, 28 Aug 2017 15:38:57 +0000 (17:38 +0200)]
gskrendernode: Constify some parameters
Timm Bäder [Mon, 28 Aug 2017 14:58:48 +0000 (16:58 +0200)]
Revert "headerbar: Avoid allocating 0 visible children"
This reverts commit
8c0e5adaab3f38de31d44dd50bcc8179b17c8b4a.
This is actually needed since GtkHeaderBar will allocate and snapshot
widget that coun_visible_children does not consider.
Fabio Tomat [Mon, 28 Aug 2017 14:40:24 +0000 (14:40 +0000)]
Update Friulian translation
Timm Bäder [Mon, 28 Aug 2017 09:17:19 +0000 (11:17 +0200)]
range: Fix trough state update
Timm Bäder [Mon, 28 Aug 2017 09:15:58 +0000 (11:15 +0200)]
popover: Initialize some locals
gtk_popover_get_pointing_to does not fill the given rect in every case.
Timm Bäder [Mon, 28 Aug 2017 09:07:35 +0000 (11:07 +0200)]
headerbar: Avoid allocating 0 visible children
Ths avoids doing a bunch of work as well as passing 0 to g_alloca which
is undefined.
Changwoo Ryu [Sun, 27 Aug 2017 21:47:55 +0000 (21:47 +0000)]
Update Korean translation
Changwoo Ryu [Sun, 27 Aug 2017 21:47:41 +0000 (21:47 +0000)]
Update Korean translation
Çağatay Yiğit Şahin [Sun, 27 Aug 2017 20:59:40 +0000 (20:59 +0000)]
Update Turkish translation
Matthias Clasen [Sun, 27 Aug 2017 20:01:24 +0000 (16:01 -0400)]
meson: Make sure ENABLE_NLS is actually defined
Despite the comment, we ended up without ENABLE_NLS.
Matthias Clasen [Sun, 27 Aug 2017 02:13:25 +0000 (22:13 -0400)]
x11: Fix managed dnd
We need to actually trigger the drop from the gdk side.
Matthias Clasen [Sat, 26 Aug 2017 23:15:36 +0000 (19:15 -0400)]
Remove an unused field
Drag contexts are objects, so there is no need to carry a
manual refcount around.
Matthias Clasen [Sat, 26 Aug 2017 22:01:17 +0000 (18:01 -0400)]
x11: Fix initial drag cursors
Under X, we were not setting the right drag cursor initially,
because at current_action == action == 0, initially. Fix this
by explicitly using the right cursor when grabbing.
Matthias Clasen [Sat, 26 Aug 2017 19:34:46 +0000 (15:34 -0400)]
wayland: Stop using subsurfaces for popovers
Subsurfaces don't currently work with our new rendering,
and this makes popovers unusable. We can go back to using
subsurfaces for popovers when this is fixed.
Timm Bäder [Fri, 25 Aug 2017 12:52:14 +0000 (14:52 +0200)]
container: Remove leftover prototype
Thanks to Murray Cumming.
Fabio Tomat [Fri, 25 Aug 2017 11:44:35 +0000 (11:44 +0000)]
Update Friulian translation
Jordi Mas [Fri, 25 Aug 2017 11:37:17 +0000 (13:37 +0200)]
Fix Catalan translation
Fabio Tomat [Fri, 25 Aug 2017 03:17:56 +0000 (03:17 +0000)]
Update Friulian translation
Daniel Boles [Thu, 24 Aug 2017 11:46:47 +0000 (12:46 +0100)]
ComboBox: Clarify documentation of get_active_iter
https://bugzilla.gnome.org/show_bug.cgi?id=618160
Daniel Boles [Wed, 23 Aug 2017 20:44:10 +0000 (21:44 +0100)]
Popover: Include window shadows in overshoot calcs
.update_position() enforces that non-Wayland platforms must position a
Popover within its parent Window. We use the allocation of the Window
to translate the position and check for overshoot on each of its sides.
Calling Widget.get_allocation() of a CSD Window includes its shadows.
But shadows were not excluded from the area in which we can position.
Thus, Popovers could get positioned in the shadow of CSD windows, where,
at least on X11, no input is received. Therefore, positioning a Popover
over a shadow meant its child widgets within that area became unusable.
Fix by calling Window.get_shadow() and including it in the overshoot on
each side. This adjusts for how the allocation includes shadows, making
overshoots with and without shadows the same. Thus, we avoid considering
shadows as viable for positioning, favouring a side where input works.
https://bugzilla.gnome.org/show_bug.cgi?id=786209
Daniel Boles [Sun, 13 Aug 2017 19:15:36 +0000 (20:15 +0100)]
testpopover: Use HeaderBar to get CSD decorations
This helps test whether the Popover positioning gets messed up by the
presence of CSD shadow or other accessories around the content area.
https://bugzilla.gnome.org/show_bug.cgi?id=786209
Cheng-Chia Tseng [Thu, 24 Aug 2017 16:40:29 +0000 (16:40 +0000)]
Update Chinese (Taiwan) translation
Piotr Drąg [Thu, 24 Aug 2017 00:45:09 +0000 (02:45 +0200)]
Update POTFILES.in and POTFILES.skip
Matthias Clasen [Wed, 23 Aug 2017 20:54:53 +0000 (16:54 -0400)]
Remove motif dnd leftovers
We don't support Motif DND anymore, so no need to look for
Motif-specific messages.
Daniel Boles [Sat, 19 Aug 2017 16:27:20 +0000 (17:27 +0100)]
SidebarRow: Add Unmount tooltip to eject_button
It was reported that the lack of a tooltip made its purpose unclear.
This can be solved by just copying PlacesViewRow’s eject_button tooltip.
https://bugzilla.gnome.org/show_bug.cgi?id=766909
Carlos Garnacho [Wed, 23 Aug 2017 11:54:46 +0000 (13:54 +0200)]
fontchooser: Block row deleted signal handler when reloading model
This prevents the load_fonts() function from switching to the "no fonts"
page and back when the model is reloaded. Given
GtkSettings::gtk-fontconfig-timestamp is 0 on Wayland and style changes
happen often, the stack change messes up popovers and pointer focus
on the fonts treeview and test entry.
Tom Schoonjans [Mon, 31 Jul 2017 20:28:42 +0000 (21:28 +0100)]
GtkFileChooserNativeQuartz: restore parent focus after closing dialog
Tested for both modal and non-modal dialogs
https://bugzilla.gnome.org/show_bug.cgi?id=785306
Tom Schoonjans [Mon, 31 Jul 2017 20:26:47 +0000 (21:26 +0100)]
GtkFileChooserNativeQuartz: improve support for file filters
Instead of using conditional compilation, use respondsToSelector to
check at runtime for setAccessoryViewDisclosed.
https://bugzilla.gnome.org/show_bug.cgi?id=785306
Tom Schoonjans [Sun, 23 Jul 2017 08:37:26 +0000 (09:37 +0100)]
GtkFileChooserNativeQuartz: add support for Mountain Lion and Mavericks
https://bugzilla.gnome.org/show_bug.cgi?id=784723 introduced support for
native file chooser dialogs on macOS, but due to the use of generics in
the patch, there will be compilation errors on pre-Xcode 7 platforms,
such as Mountain Lion and Mavericks.
I strongly recommend to revert this patch when the oldest supported
macOS release is bumped to Yosemite (10.10).
https://bugzilla.gnome.org/show_bug.cgi?id=785306
Matthias Clasen [Wed, 23 Aug 2017 14:40:12 +0000 (10:40 -0400)]
Revert "wayland: fix filechooser crash"
This reverts commit
bd033165e52469845ac6f69c4fa9ac9b897f9bcc.
The function already had an early exit, no need for this check.
Lionel Landwerlin [Wed, 23 Aug 2017 14:22:47 +0000 (15:22 +0100)]
wayland: fix filechooser crash
The opaque region of the window can be updated before we're requested
its creation on the compositor.
https://bugzilla.gnome.org/show_bug.cgi?id=786673
Matthias Clasen [Wed, 23 Aug 2017 14:27:43 +0000 (10:27 -0400)]
wayland: fix filechooser crash
The size of the window can be updated before we're requested its
creation on the compositor.
https://bugzilla.gnome.org/show_bug.cgi?id=786673
Timm Bäder [Wed, 23 Aug 2017 13:00:59 +0000 (15:00 +0200)]
magnifier: Port to snapshot
Instead of gtk_widget_draw'in the inspected widget inside the
magnifier's ::draw handler, just create a new GtkSnapshot and snapshot
in its snapshot handler, similar to what GtkStack is doing.
Fabio Tomat [Wed, 23 Aug 2017 13:50:20 +0000 (13:50 +0000)]
Update Friulian translation
Timm Bäder [Wed, 23 Aug 2017 11:58:21 +0000 (13:58 +0200)]
widget: Fix UPDATES debug rendering
Choose the right widget to add the debug updates to (the one with the
window) and the correct region (the one in that window's coordinates).
Timm Bäder [Wed, 23 Aug 2017 09:05:20 +0000 (11:05 +0200)]
testgtk: Remove some invalid css
Timm Bäder [Mon, 21 Aug 2017 10:40:41 +0000 (12:40 +0200)]
widget: Remove unused draw_internal prototype
gtk_widget_draw_internal is now only used inside gtkwidget.c, so remove
the prototype from gtkwidgetprivate.h. And since all incovacations call
it with clip_to_size=TRUE, remove that parameter.
Milo Casagrande [Wed, 23 Aug 2017 07:18:25 +0000 (07:18 +0000)]
Update Italian translation
Milo Casagrande [Wed, 23 Aug 2017 07:14:01 +0000 (07:14 +0000)]
Update Italian translation
Aurimas Černius [Tue, 22 Aug 2017 20:06:07 +0000 (23:06 +0300)]
Updated Lithuanian translation
Daniel Boles [Tue, 22 Aug 2017 13:14:53 +0000 (14:14 +0100)]
getting_started: Sync filenames & section headings
The order of Examples 3 and 4 was swapped, so the headings updated
themselves, but the filenames were left reflecting the old order.
https://bugzilla.gnome.org/show_bug.cgi?id=786553
Matthias Clasen [Sat, 19 Aug 2017 18:05:48 +0000 (14:05 -0400)]
Handle emoji data change in emoji chooser
Update the settings schema to follow the change in Emoji data,
and make the emoji chooser code handle the new format.
Matthias Clasen [Sat, 19 Aug 2017 18:05:16 +0000 (14:05 -0400)]
Add shortnames to emoji data
The json file is from
https://github.com/emojione/emojione/tree/master/extras/alpha-codes
It is under the MIT license.
Matthias Clasen [Tue, 22 Aug 2017 10:41:31 +0000 (06:41 -0400)]
Don't consume too many key releases
The Emoji input support in GtkIMContextSimple was
unintentionally consuming too many key release
events. Fix this.
https://bugzilla.gnome.org/show_bug.cgi?id=786594
Emmanuele Bassi [Tue, 22 Aug 2017 09:27:14 +0000 (10:27 +0100)]
build: Use the appropriate symbol visibility annotation
We cargo-culted this from Autotools, but GCC on Windows supports the
same __declspec syntax as MSVC. The only difference is the additional
flag needed for GCC-like compilers.
Emmanuele Bassi [Tue, 22 Aug 2017 09:24:45 +0000 (10:24 +0100)]
build: Fix macOS linker compatibility flags
The linker on macOS does not support '=' in its command line; there's no
guarantee that we are using the correct compatibility versions compared
to the Autotools build, but for that we'll need to build GTK+ master on
macOS.
Emmanuele Bassi [Tue, 22 Aug 2017 09:20:45 +0000 (10:20 +0100)]
build: Allow using libepoxy as a subproject
Like we do for Graphene, we can build libepoxy as a sub-project of GTK+
in case we do not find the dependency installed on the system.
Daniel Mustieles [Mon, 21 Aug 2017 11:36:06 +0000 (11:36 +0000)]
Update Spanish translation
Timm Bäder [Mon, 21 Aug 2017 10:12:50 +0000 (12:12 +0200)]
container: Fix scrolling adjustment coordinates
Timm Bäder [Mon, 21 Aug 2017 07:33:14 +0000 (09:33 +0200)]
container: Remove gtk_container_propagate_draw
It's superseded by gtk_widget_snapshot_child now.
Timm Bäder [Mon, 21 Aug 2017 07:25:32 +0000 (09:25 +0200)]
textview: Draw children using gtk_widget_snapshot_child
Pawan Chitrakar [Sun, 20 Aug 2017 23:49:13 +0000 (23:49 +0000)]
Update Nepali translation
Pawan Chitrakar [Sun, 20 Aug 2017 23:42:21 +0000 (23:42 +0000)]
Update Nepali translation
Anish Sheela [Sun, 20 Aug 2017 21:00:03 +0000 (21:00 +0000)]
Update Malayalam translation
Mario Blättermann [Sun, 20 Aug 2017 18:03:19 +0000 (18:03 +0000)]
Update German translation
Baurzhan Muftakhidinov [Sun, 20 Aug 2017 16:06:09 +0000 (16:06 +0000)]
Update Kazakh translation
Alexandre Franke [Sat, 19 Aug 2017 14:48:49 +0000 (14:48 +0000)]
Update French translation
Alexandre Franke [Sat, 19 Aug 2017 14:46:50 +0000 (14:46 +0000)]
Update French translation
Мирослав Николић [Sat, 19 Aug 2017 13:45:15 +0000 (15:45 +0200)]
Updated Serbian translation
Mario Blättermann [Sat, 19 Aug 2017 11:50:58 +0000 (11:50 +0000)]
Update German translation
Timm Bäder [Sat, 19 Aug 2017 09:43:29 +0000 (11:43 +0200)]
widget: Remove outdated comment about widget coordinates
Not so odd anymore.
Timm Bäder [Wed, 16 Aug 2017 08:37:17 +0000 (10:37 +0200)]
Remove gdk_event_get_user_data from public headers
And add it back in gdk-private.h
Lionel Landwerlin [Fri, 18 Aug 2017 22:57:56 +0000 (23:57 +0100)]
gdk: wayland: always set buffer scale on size update
We're only updating this when we have an EGL window. This means we
have the wrong scaling factor when using Vulkan.
https://bugzilla.gnome.org/show_bug.cgi?id=786492
Lionel Landwerlin [Fri, 18 Aug 2017 19:38:54 +0000 (20:38 +0100)]
gsk: vulkan: fix image uploading
The memory alignment requirements are different from the image layout.
We want the rowPitch to know where to upload the lines.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
https://bugzilla.gnome.org/show_bug.cgi?id=786485
gogo [Fri, 18 Aug 2017 20:34:30 +0000 (20:34 +0000)]
Update Croatian translation
gogo [Fri, 18 Aug 2017 20:31:56 +0000 (20:31 +0000)]
Update Croatian translation
Rui Matos [Fri, 18 Aug 2017 10:01:54 +0000 (12:01 +0200)]
gdkwindow: Avoid re-setting the opaque region if it doesn't change
This avoids, at least, needless chatter with the compositor and the X
server in X11's case.
https://bugzilla.gnome.org/show_bug.cgi?id=786469
Dušan Kazik [Fri, 18 Aug 2017 16:09:11 +0000 (16:09 +0000)]
Update Slovak translation